From 7c4688f5571475a92fe73852beebfd3287d5e0f8 Mon Sep 17 00:00:00 2001 From: IgnacioFDM Date: Fri, 9 Mar 2018 15:37:46 -0300 Subject: [PATCH] Comment MODULE_RELOAD_ON_MAP_CHANGE on modules that use USE_METAMOD (#484) Currently amxmodx doesn't reload modules that use metamod, so MODULE_RELOAD_ON_MAP_CHANGE being defined or not doesn't make any difference. Even though this commit currently doesn't change any behavior, amxmodx might in the future support reloading modules that use metamod, and all these modules in their current state either fail completely because of erroneous cleanup, or are untested (and most likely leak stuff). Furthermore, these changes make it clear that these modules are in fact not being reloaded. --- modules/cstrike/cstrike/moduleconfig.h | 2 +- modules/cstrike/csx/moduleconfig.h | 2 +- modules/dod/dodfun/moduleconfig.h | 2 +- modules/dod/dodx/moduleconfig.h | 2 +- modules/engine/moduleconfig.h | 2 +- modules/fakemeta/moduleconfig.h | 2 +- modules/fun/moduleconfig.h | 2 +- modules/geoip/moduleconfig.h | 2 +- modules/mysqlx/moduleconfig.h | 2 +- modules/sqlite/moduleconfig.h | 2 +- modules/tfcx/moduleconfig.h | 2 +- modules/ts/tsx/moduleconfig.h | 2 +- 12 files changed, 12 insertions(+), 12 deletions(-) diff --git a/modules/cstrike/cstrike/moduleconfig.h b/modules/cstrike/cstrike/moduleconfig.h index 40c9d222..d32a9740 100644 --- a/modules/cstrike/cstrike/moduleconfig.h +++ b/modules/cstrike/cstrike/moduleconfig.h @@ -25,7 +25,7 @@ #define MODULE_LIBRARY "cstrike" #define MODULE_LIBCLASS "" // If you want the module not to be reloaded on mapchange, remove / comment out the next line -#define MODULE_RELOAD_ON_MAPCHANGE +// #define MODULE_RELOAD_ON_MAPCHANGE #ifdef __DATE__ #define MODULE_DATE __DATE__ diff --git a/modules/cstrike/csx/moduleconfig.h b/modules/cstrike/csx/moduleconfig.h index 6f0ad412..774f15f6 100644 --- a/modules/cstrike/csx/moduleconfig.h +++ b/modules/cstrike/csx/moduleconfig.h @@ -25,7 +25,7 @@ #define MODULE_LIBRARY "csx" #define MODULE_LIBCLASS "xstats" // If you want the module not to be reloaded on mapchange, remove / comment out the next line -#define MODULE_RELOAD_ON_MAPCHANGE +// #define MODULE_RELOAD_ON_MAPCHANGE #ifdef __DATE__ #define MODULE_DATE __DATE__ diff --git a/modules/dod/dodfun/moduleconfig.h b/modules/dod/dodfun/moduleconfig.h index c536673f..63540232 100644 --- a/modules/dod/dodfun/moduleconfig.h +++ b/modules/dod/dodfun/moduleconfig.h @@ -25,7 +25,7 @@ #define MODULE_LIBRARY "dodfun" #define MODULE_LIBCLASS "" // If you want the module not to be reloaded on mapchange, remove / comment out the next line -#define MODULE_RELOAD_ON_MAPCHANGE +// #define MODULE_RELOAD_ON_MAPCHANGE #ifdef __DATE__ #define MODULE_DATE __DATE__ diff --git a/modules/dod/dodx/moduleconfig.h b/modules/dod/dodx/moduleconfig.h index b58dff95..e3f710a9 100644 --- a/modules/dod/dodx/moduleconfig.h +++ b/modules/dod/dodx/moduleconfig.h @@ -25,7 +25,7 @@ #define MODULE_LIBRARY "dodx" #define MODULE_LIBCLASS "xstats" // If you want the module not to be reloaded on mapchange, remove / comment out the next line -#define MODULE_RELOAD_ON_MAPCHANGE +// #define MODULE_RELOAD_ON_MAPCHANGE #ifdef __DATE__ #define MODULE_DATE __DATE__ diff --git a/modules/engine/moduleconfig.h b/modules/engine/moduleconfig.h index 64bf82ba..12e356c3 100644 --- a/modules/engine/moduleconfig.h +++ b/modules/engine/moduleconfig.h @@ -25,7 +25,7 @@ #define MODULE_LIBRARY "engine" #define MODULE_LIBCLASS "" // If you want the module not to be reloaded on mapchange, remove / comment out the next line -#define MODULE_RELOAD_ON_MAPCHANGE +// #define MODULE_RELOAD_ON_MAPCHANGE #ifdef __DATE__ #define MODULE_DATE __DATE__ diff --git a/modules/fakemeta/moduleconfig.h b/modules/fakemeta/moduleconfig.h index 052ead4b..b02728fd 100644 --- a/modules/fakemeta/moduleconfig.h +++ b/modules/fakemeta/moduleconfig.h @@ -25,7 +25,7 @@ #define MODULE_LIBRARY "fakemeta" #define MODULE_LIBCLASS "" // If you want the module not to be reloaded on mapchange, remove / comment out the next line -#define MODULE_RELOAD_ON_MAPCHANGE +// #define MODULE_RELOAD_ON_MAPCHANGE #ifdef __DATE__ #define MODULE_DATE __DATE__ diff --git a/modules/fun/moduleconfig.h b/modules/fun/moduleconfig.h index 0e492a7a..06c8b963 100644 --- a/modules/fun/moduleconfig.h +++ b/modules/fun/moduleconfig.h @@ -26,7 +26,7 @@ #define MODULE_LIBRARY "fun" #define MODULE_LIBCLASS "" // If you want the module not to be reloaded on mapchange, remove / comment out the next line -#define MODULE_RELOAD_ON_MAPCHANGE +// #define MODULE_RELOAD_ON_MAPCHANGE #ifdef __DATE__ #define MODULE_DATE __DATE__ diff --git a/modules/geoip/moduleconfig.h b/modules/geoip/moduleconfig.h index 67fd54fa..b29ab017 100644 --- a/modules/geoip/moduleconfig.h +++ b/modules/geoip/moduleconfig.h @@ -25,7 +25,7 @@ #define MODULE_LIBRARY "geoip" #define MODULE_LIBCLASS "" // If you want the module not to be reloaded on mapchange, remove / comment out the next line -#define MODULE_RELOAD_ON_MAPCHANGE +// #define MODULE_RELOAD_ON_MAPCHANGE #ifdef __DATE__ #define MODULE_DATE __DATE__ diff --git a/modules/mysqlx/moduleconfig.h b/modules/mysqlx/moduleconfig.h index cc9d2de5..1f251f42 100644 --- a/modules/mysqlx/moduleconfig.h +++ b/modules/mysqlx/moduleconfig.h @@ -35,7 +35,7 @@ #define MODULE_LIBRARY "mysql" #define MODULE_LIBCLASS "sqlx" // If you want the module not to be reloaded on mapchange, remove / comment out the next line -#define MODULE_RELOAD_ON_MAPCHANGE +// #define MODULE_RELOAD_ON_MAPCHANGE #ifdef __DATE__ #define MODULE_DATE __DATE__ diff --git a/modules/sqlite/moduleconfig.h b/modules/sqlite/moduleconfig.h index d7ccc94b..cbdc9659 100644 --- a/modules/sqlite/moduleconfig.h +++ b/modules/sqlite/moduleconfig.h @@ -25,7 +25,7 @@ #define MODULE_LIBRARY "sqlite" #define MODULE_LIBCLASS "sqlx" // If you want the module not to be reloaded on mapchange, remove / comment out the next line -#define MODULE_RELOAD_ON_MAPCHANGE +// #define MODULE_RELOAD_ON_MAPCHANGE #ifdef __DATE__ #define MODULE_DATE __DATE__ diff --git a/modules/tfcx/moduleconfig.h b/modules/tfcx/moduleconfig.h index 2107c971..9b556ef6 100644 --- a/modules/tfcx/moduleconfig.h +++ b/modules/tfcx/moduleconfig.h @@ -26,7 +26,7 @@ #define MODULE_LIBRARY "tfcx" #define MODULE_LIBCLASS "xstats" // If you want the module not to be reloaded on mapchange, remove / comment out the next line -#define MODULE_RELOAD_ON_MAPCHANGE +// #define MODULE_RELOAD_ON_MAPCHANGE #ifdef __DATE__ #define MODULE_DATE __DATE__ diff --git a/modules/ts/tsx/moduleconfig.h b/modules/ts/tsx/moduleconfig.h index 1d9e28c5..f551986d 100644 --- a/modules/ts/tsx/moduleconfig.h +++ b/modules/ts/tsx/moduleconfig.h @@ -26,7 +26,7 @@ #define MODULE_LIBRARY "tsx" #define MODULE_LIBCLASS "xstats" // If you want the module not to be reloaded on mapchange, remove / comment out the next line -#define MODULE_RELOAD_ON_MAPCHANGE +// #define MODULE_RELOAD_ON_MAPCHANGE #ifdef __DATE__ #define MODULE_DATE __DATE__