GitHub/amxmodx
2
0
Fork 0
mirror of https://github.com/alliedmodders/amxmodx.git synced 2024-12-24 13:55:36 +03:00
Code Issues Projects Releases Wiki Activity

CVector fix - corrupt memory on size change

Browse Source
This commit is contained in:
David Anderson 2005-07-23 16:58:10 +00:00
parent e188bf087a
commit 9e194394c3
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
dlls/engine/CVector.h
View File

@ -48,7 +48,8 @@ template <class T> class CVector
return false; return false;
if (m_Data) if (m_Data)
{ {
memcpy(newData, m_Data, m_Size * sizeof(T)); for (size_t i=0; i<m_CurrentUsedSize; i++)
newData[i] = m_Data[i];
delete [] m_Data; delete [] m_Data;
} }
m_Data = newData; m_Data = newData;
@ -74,7 +75,9 @@ template <class T> class CVector
return false; return false;
if (m_Data) if (m_Data)
{ {
memcpy(newData, m_Data, (m_Size < size) ? (m_Size * sizeof(T)) : (size * sizeof(T))); size_t end = (m_Size < size) ? (m_Size) : size;
for (size_t i=0; i<end; i++)
newData[i] = m_Data[i];
delete [] m_Data; delete [] m_Data;
} }
if (m_Size < size) if (m_Size < size)
@ -251,10 +254,11 @@ public:
CVector<T>(const CVector<T> & other) CVector<T>(const CVector<T> & other)
{ {
// copy data // copy data
m_Data = new T [other.m_Size]; m_Data = new T [other.m_CurrentUsedSize];
m_Size = other.m_Size; m_Size = other.m_CurrentUsedSize;
m_CurrentUsedSize = other.m_CurrentUsedSize; m_CurrentUsedSize = other.m_CurrentUsedSize;
memcpy(m_Data, other.m_Data, m_CurrentUsedSize * sizeof(T)); for (size_t i=0; i<other.m_CurrentUsedSize; i++)
m_Data[i] = other.m_Data[i];
} }
~CVector<T>() ~CVector<T>()