GitHub/skyline
2
0
Fork 0
mirror of https://github.com/skyline-emu/skyline.git synced 2024-12-29 17:55:28 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix Texture Handle Offset Calculation

Browse Source 
The texture handle offset calculation involved an incorrect shift by descriptor size which was found to be unnecessary and would result in an invalid handle that had the wrong TIC/TSC index and caused broken rendering.
This commit is contained in:
PixelyIon 2022-01-22 19:13:16 +05:30
parent aa57ec6d55
commit 0b2ce6a8f3
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/src/main/cpp/skyline/gpu/interconnect/graphics_context.h
View File

@ -949,7 +949,6 @@ namespace skyline::gpu::interconnect {
.pImageInfo = imageInfo.data() + imageInfo.size(), .pImageInfo = imageInfo.data() + imageInfo.size(),
}); });
u32 descriptorIndex{};
for (auto &texture : program.info.texture_descriptors) { for (auto &texture : program.info.texture_descriptors) {
layoutBindings.push_back(vk::DescriptorSetLayoutBinding{ layoutBindings.push_back(vk::DescriptorSetLayoutBinding{
.binding = bindingIndex++, .binding = bindingIndex++,
@ -965,7 +964,7 @@ namespace skyline::gpu::interconnect {
u32 textureIndex : 20; u32 textureIndex : 20;
u32 samplerIndex : 12; u32 samplerIndex : 12;
}; };
} handle{constantBuffer.Read<u32>(texture.cbuf_offset + (descriptorIndex++ << texture.size_shift))}; } handle{constantBuffer.Read<u32>(texture.cbuf_offset)};
auto sampler{GetSampler(handle.samplerIndex)}; auto sampler{GetSampler(handle.samplerIndex)};
auto textureView{GetPoolTextureView(handle.textureIndex)}; auto textureView{GetPoolTextureView(handle.textureIndex)};