GitHub/skyline
2
0
Fork 0
mirror of https://github.com/skyline-emu/skyline.git synced 2024-12-29 17:35:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix Maxwell3D Blend Enum Conversion Bugs

Browse Source 
The `OneMinusSourceAlpha` blending factor was converted to `eOneMinusSrcColor` rather than `eOneMinusSrcAlpha` leading to incorrect blending behavior in certain titles. A similar issue with the order of `MinimumGL`/`MaximumGL` and `SubtractGL`/`ReverseSubtractGL` being the opposite of what it should've been, both of these issues have been fixed.
This commit is contained in:
PixelyIon 2022-01-11 19:57:21 +05:30
parent 0a506088f4
commit 21a6866def
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/cpp/skyline/gpu/interconnect/graphics_context.h
View File

@ -1210,7 +1210,7 @@ namespace skyline::gpu::interconnect {
case maxwell3d::BlendFactor::OneMinusSourceAlpha: case maxwell3d::BlendFactor::OneMinusSourceAlpha:
case maxwell3d::BlendFactor::OneMinusSourceAlphaGL: case maxwell3d::BlendFactor::OneMinusSourceAlphaGL:
return vk::BlendFactor::eOneMinusSrcColor; return vk::BlendFactor::eOneMinusSrcAlpha;
case maxwell3d::BlendFactor::DestAlpha: case maxwell3d::BlendFactor::DestAlpha:
case maxwell3d::BlendFactor::DestAlphaGL: case maxwell3d::BlendFactor::DestAlphaGL:

8
app/src/main/cpp/skyline/soc/gm20b/engines/maxwell/types.h
View File

@ -393,10 +393,10 @@ namespace skyline::soc::gm20b::engine::maxwell3d::type {
Maximum = 5, Maximum = 5,
AddGL = 0x8006, AddGL = 0x8006,
SubtractGL = 0x8007, MinimumGL = 0x8007,
ReverseSubtractGL = 0x8008, MaximumGL = 0x8008,
MinimumGL = 0x800A, SubtractGL = 0x800A,
MaximumGL = 0x800B, ReverseSubtractGL = 0x800B,
}; };
enum class BlendFactor : u32 { enum class BlendFactor : u32 {