GitHub/skyline
2
0
Fork 0
mirror of https://github.com/skyline-emu/skyline.git synced 2024-12-29 16:55:28 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix Viewport X/Y Translation

Browse Source 
The operands of the subtraction in the X/Y translation calculation were the wrong way around which led to negative translations that would translate the viewport off the screen.
This commit is contained in:
PixelyIon 2021-12-07 01:03:22 +05:30
parent f06a12170f
commit 353ca8ec84
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/main/cpp/skyline/gpu/interconnect/graphics_context.h
View File

@ -284,13 +284,13 @@ namespace skyline::gpu::interconnect {
*/ */
void SetViewportX(size_t index, float scale, float translate) { void SetViewportX(size_t index, float scale, float translate) {
auto &viewport{viewports.at(index)}; auto &viewport{viewports.at(index)};
viewport.x = scale - translate; // Counteract the addition of the half of the width (o_x) to the host translation viewport.x = translate - scale; // Counteract the addition of the half of the width (o_x) to the host translation
viewport.width = scale * 2.0f; // Counteract the division of the width (p_x) by 2 for the host scale viewport.width = scale * 2.0f; // Counteract the division of the width (p_x) by 2 for the host scale
} }
void SetViewportY(size_t index, float scale, float translate) { void SetViewportY(size_t index, float scale, float translate) {
auto &viewport{viewports.at(index)}; auto &viewport{viewports.at(index)};
viewport.y = scale - translate; // Counteract the addition of the half of the height (p_y/2 is center) to the host translation (o_y) viewport.y = translate - scale; // Counteract the addition of the half of the height (p_y/2 is center) to the host translation (o_y)
viewport.height = scale * 2.0f; // Counteract the division of the height (p_y) by 2 for the host scale viewport.height = scale * 2.0f; // Counteract the division of the height (p_y) by 2 for the host scale
} }