GitHub/skyline
2
0
Fork 0
mirror of https://github.com/skyline-emu/skyline.git synced 2024-12-28 08:35:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

Remove Maxwell3D Zero Initialization Calls

Browse Source 
A lot of calls in Maxwell3D register initialization ended up setting the register to 0 which should be implicit behavior and most calls would be eliminated by the redundancy check which had to be manually disabled. It was determined to be better to move this responsibility to the called function to initialize to state equivalent to the corresponding register being 0. All initialization calls with the argument as 0 have been removed now due to this, it was the vast majority of calls.
This commit is contained in:
PixelyIon 2021-11-12 14:29:17 +05:30
parent 49cc0964e2
commit 586bee2c59
3 changed files with 4 additions and 960 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

956
app/src/main/cpp/skyline/soc/gm20b/engines/maxwell/initialization.cpp
View File

File diff suppressed because it is too large Load Diff

6
app/src/main/cpp/skyline/soc/gm20b/engines/maxwell_3d.cpp
View File

@ -41,10 +41,10 @@ namespace skyline::soc::gm20b::engine::maxwell3d {
return;
}
HandleMethod(method, argument, true);
HandleMethod(method, argument);
}
void Maxwell3D::HandleMethod(u32 method, u32 argument, bool redundantCheck) {
void Maxwell3D::HandleMethod(u32 method, u32 argument) {
#define MAXWELL3D_OFFSET(field) (sizeof(typeof(Registers::field)) - sizeof(typeof(*Registers::field))) / sizeof(u32)
#define MAXWELL3D_STRUCT_OFFSET(field, member) MAXWELL3D_OFFSET(field) + U32_OFFSET(typeof(*Registers::field), member)
#define MAXWELL3D_ARRAY_OFFSET(field, index) MAXWELL3D_OFFSET(field) + ((sizeof(typeof(Registers::field[0])) / sizeof(u32)) * index)
@ -73,7 +73,7 @@ namespace skyline::soc::gm20b::engine::maxwell3d {
argument = shadowRegisters.raw[method];
}
bool redundant{redundantCheck && registers.raw[method] == argument};
bool redundant{registers.raw[method] == argument};
registers.raw[method] = argument;
if (!redundant) {

2
app/src/main/cpp/skyline/soc/gm20b/engines/maxwell_3d.h
View File

@ -32,7 +32,7 @@ namespace skyline::soc::gm20b::engine::maxwell3d {
/**
* @brief Calls the appropriate function corresponding to a certain method with the supplied argument
*/
void HandleMethod(u32 method, u32 argument, bool redundantCheck = false);
void HandleMethod(u32 method, u32 argument);
/**
* @brief Writes back a semaphore result to the guest with an auto-generated timestamp (if required)