GitHub/skyline
GitHub/skyline
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix hole punching in mappings with SVC UnmapPhysicalMemory

Browse source 
Certain titles such as Super Smash Bros Ultimate can use SVC `UnmapPhysicalMemory` to punch holes into physical memory mappings, this wasn't handled correctly as we completely deleted the portion after the hole. It has now been fixed which results in these titles which depend on this behavior to work now.
This commit is contained in:
PixelyIon 2023-01-11 21:53:48 +05:30 • committed by Billy Laws
commit 8bfda0d84d
1 changed files with 3 additions and 0 deletions

3
app/src/main/cpp/skyline/kernel/svc.cpp
View file

@ -1084,6 +1084,9 @@ namespace skyline::kernel::svc {
}
} else if (memory->guest.data() < pointer) {
memory->Resize(static_cast<size_t>(pointer - memory->guest.data()));
if (memory->guest.data() + initialSize > end)
state.process->NewHandle<type::KPrivateMemory>(span<u8>{end, static_cast<size_t>(memory->guest.data() + initialSize - end)}, memory::Permission{true, true, false}, memory::states::Heap);
}
}
pointer += initialSize;