GitHub/skyline
2
0
Fork 0
mirror of https://github.com/skyline-emu/skyline.git synced 2024-12-29 01:55:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

Support partially mapped cbufs

Browse Source 
Buggy games sometimes supply an incorrect cbuf size so limit buffers to the first unmapped region.
This commit is contained in:
Billy Laws 2022-01-12 22:59:00 +00:00 committed by PixelyIon
parent 6a6f51ea84
commit 99652c5eda
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/cpp/skyline/common/span.h
View File

@ -89,7 +89,7 @@ namespace skyline {
/** /**
* @return If the span is valid by not being null * @return If the span is valid by not being null
*/ */
constexpr bool valid() { constexpr bool valid() const {
return this->data() != nullptr; return this->data() != nullptr;
} }

5
app/src/main/cpp/skyline/gpu/interconnect/graphics_context.h
View File

@ -4,6 +4,7 @@
#pragma once #pragma once
#include <boost/container/static_vector.hpp> #include <boost/container/static_vector.hpp>
#include <range/v3/algorithm.hpp>
#include <gpu/texture/format.h> #include <gpu/texture/format.h>
#include <gpu/buffer_manager.h> #include <gpu/buffer_manager.h>
#include <soc/gm20b/channel.h> #include <soc/gm20b/channel.h>
@ -603,6 +604,10 @@ namespace skyline::gpu::interconnect {
return constantBufferSelector; return constantBufferSelector;
auto mappings{channelCtx.asCtx->gmmu.TranslateRange(constantBufferSelector.iova, constantBufferSelector.size)}; auto mappings{channelCtx.asCtx->gmmu.TranslateRange(constantBufferSelector.iova, constantBufferSelector.size)};
// Ignore unmapped areas from mappings due to buggy games setting the wrong cbuf size
mappings.erase(ranges::find_if(mappings, [](const auto &mapping) { return !mapping.valid(); }), mappings.end());
constantBufferSelector.guest.mappings.assign(mappings.begin(), mappings.end()); constantBufferSelector.guest.mappings.assign(mappings.begin(), mappings.end());
constantBufferSelector.view = gpu.buffer.FindOrCreate(constantBufferSelector.guest); constantBufferSelector.view = gpu.buffer.FindOrCreate(constantBufferSelector.guest);