GitHub/skyline
2
0
Fork 0
mirror of https://github.com/skyline-emu/skyline.git synced 2024-12-29 16:55:28 +03:00
Code Issues Packages Projects Releases Wiki Activity

Mark GPU resources as dirty before GPU usage

Browse Source 
We didn't call `MarkGpuDirty` on textures/buffers prior to GPU usage, this would cause them to not be R/W protected when they should be and provide outdated copies if there were any read accesses from the CPU (which are not possible at the moment since we assume all accesses are writes at the moment). This has now been fixed by calling it after synchronizing the resource.
This commit is contained in:
PixelyIon 2022-04-14 17:20:05 +05:30
parent 41a6afed01
commit a1c06e0401
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/src/main/cpp/skyline/gpu/interconnect/command_executor.cpp
View File

@ -142,11 +142,14 @@ namespace skyline::gpu::interconnect {
.flags = vk::CommandBufferUsageFlagBits::eOneTimeSubmit, .flags = vk::CommandBufferUsageFlagBits::eOneTimeSubmit,
}); });
for (auto texture : syncTextures) for (auto texture : syncTextures) {
texture->SynchronizeHostWithBuffer(commandBuffer, cycle, true); texture->SynchronizeHostWithBuffer(commandBuffer, cycle, true);
texture->MarkGpuDirty();
}
for (const auto& delegate : syncBuffers) { for (const auto& delegate : syncBuffers) {
delegate->buffer->SynchronizeHostWithCycle(cycle, true); delegate->buffer->SynchronizeHostWithCycle(cycle, true);
delegate->buffer->MarkGpuDirty();
delegate->usageCallback = nullptr; delegate->usageCallback = nullptr;
} }