GitHub/skyline
2
0
Fork 0
mirror of https://github.com/skyline-emu/skyline.git synced 2024-12-29 12:35:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

Cache staging buffer used for texture download

Browse Source
This commit is contained in:
Billy Laws 2022-11-25 12:34:05 +00:00
parent 8c5e6d2bb4
commit af7c54297f
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/src/main/cpp/skyline/gpu/texture/texture.cpp
View File

@ -825,15 +825,16 @@ namespace skyline::gpu {
WaitOnBacking(); WaitOnBacking();
if (tiling == vk::ImageTiling::eOptimal || !std::holds_alternative<memory::Image>(backing)) { if (tiling == vk::ImageTiling::eOptimal || !std::holds_alternative<memory::Image>(backing)) {
auto stagingBuffer{gpu.memory.AllocateStagingBuffer(surfaceSize)}; if (!downloadStagingBuffer)
downloadStagingBuffer = gpu.memory.AllocateStagingBuffer(surfaceSize);
WaitOnFence(); WaitOnFence();
auto lCycle{gpu.scheduler.Submit([&](vk::raii::CommandBuffer &commandBuffer) { auto lCycle{gpu.scheduler.Submit([&](vk::raii::CommandBuffer &commandBuffer) {
CopyIntoStagingBuffer(commandBuffer, stagingBuffer); CopyIntoStagingBuffer(commandBuffer, downloadStagingBuffer);
})}; })};
lCycle->Wait(); // We block till the copy is complete lCycle->Wait(); // We block till the copy is complete
CopyToGuest(stagingBuffer->data()); CopyToGuest(downloadStagingBuffer->data());
} else if (tiling == vk::ImageTiling::eLinear) { } else if (tiling == vk::ImageTiling::eLinear) {
// We can optimize linear texture sync on a UMA by mapping the texture onto the CPU and copying directly from it rather than using a staging buffer // We can optimize linear texture sync on a UMA by mapping the texture onto the CPU and copying directly from it rather than using a staging buffer
WaitOnFence(); WaitOnFence();

2
app/src/main/cpp/skyline/gpu/texture/texture.h
View File

@ -406,6 +406,8 @@ namespace skyline::gpu {
std::vector<TextureViewStorage> views; std::vector<TextureViewStorage> views;
std::shared_ptr<memory::StagingBuffer> downloadStagingBuffer{};
u32 lastRenderPassIndex{}; //!< The index of the last render pass that used this texture u32 lastRenderPassIndex{}; //!< The index of the last render pass that used this texture
texture::RenderPassUsage lastRenderPassUsage{texture::RenderPassUsage::None}; //!< The type of usage in the last render pass texture::RenderPassUsage lastRenderPassUsage{texture::RenderPassUsage::None}; //!< The type of usage in the last render pass