GitHub/skyline
2
0
Fork 0
mirror of https://github.com/skyline-emu/skyline.git synced 2025-04-09 12:19:59 +03:00
Code Issues Packages Projects Releases Wiki Activity

Validate if entries are not empty before using

Browse Source 
Should fix saving problem in Baldur's Gate: Dark Alliance II at least
This commit is contained in:
Dima 2022-11-29 10:14:43 +03:00 committed by Billy Laws
parent 5f510d84d7
commit bbd34ae7e7
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
app/src/main/cpp/skyline/services/fssrv/IDirectory.cpp
View File

@ -28,17 +28,18 @@ namespace skyline::service::fssrv {
auto outputEntries{request.outputBuf.at(0).cast<DirectoryEntry, std::dynamic_extent, true>()}; auto outputEntries{request.outputBuf.at(0).cast<DirectoryEntry, std::dynamic_extent, true>()};
size_t i{}; size_t i{};
for (; i < std::min(entries.size() - remainingReadCount, outputEntries.size()); i++) { if (!entries.empty())
auto &entry{entries.at(i)}; for (; i < std::min(entries.size() - remainingReadCount, outputEntries.size()); i++) {
auto &entry{entries.at(i)};
outputEntries[i] = { outputEntries[i] = {
.type = entry.type, .type = entry.type,
.attributes.directory = (entry.type == vfs::Directory::EntryType::Directory), .attributes.directory = (entry.type == vfs::Directory::EntryType::Directory),
.size = entry.size, .size = entry.size,
}; };
span(outputEntries[i].name).copy_from(entry.name); span(outputEntries[i].name).copy_from(entry.name);
} }
remainingReadCount += i; remainingReadCount += i;
response.Push<u64>(i); response.Push<u64>(i);