GitHub/skyline
2
0
Fork 0
mirror of https://github.com/skyline-emu/skyline.git synced 2024-12-28 09:05:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

Make accesses to setting values thread-safe

Browse Source
This commit is contained in:
lynxnb 2022-07-19 14:05:16 +02:00 committed by ◱ Mark
parent 30667a0899
commit d183d14e2a
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
app/src/main/cpp/skyline/common/settings.h
View File

@ -15,11 +15,15 @@ namespace skyline {
using Callback = std::function<void(const T &)>;
std::vector<Callback> callbacks; //!< Callbacks to be called when this setting changes
T value;
std::mutex valueMutex;
std::mutex callbackMutex;
/**
* @brief Calls all callbacks registered for this setting
* @note Locking of the setting value must be handled by the caller
*/
void OnSettingChanged() {
std::scoped_lock lock{callbackMutex};
for (const auto &callback : callbacks)
callback(value);
}
@ -28,7 +32,8 @@ namespace skyline {
/**
* @return The underlying setting value
*/
const T &operator*() const {
const T &operator*() {
std::scoped_lock lock{valueMutex};
return value;
}
@ -36,6 +41,7 @@ namespace skyline {
* @brief Sets the underlying setting value, signalling any callbacks if necessary
*/
void operator=(T newValue) {
std::scoped_lock lock{valueMutex};
if (value != newValue) {
value = std::move(newValue);
OnSettingChanged();
@ -46,6 +52,7 @@ namespace skyline {
* @brief Register a callback to be run when this setting changes
*/
void AddCallback(Callback callback) {
std::scoped_lock lock{callbackMutex};
callbacks.push_back(std::move(callback));
}
};