GitHub/skyline
2
0
Fork 0
mirror of https://github.com/skyline-emu/skyline.git synced 2024-12-28 22:25:30 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix Mapping Caching For Maxwell 3D Buffers

Browse Source 
Code involving caching of mappings was copied from `RenderTarget` without much consideration for applicability in buffers, the reason for caching mappings in RTs was that the view may be invalidated by more than the IOVA/Size being changed but this doesn't hold true for buffers generally so invalidation can only be on the view level with the mappings being looked up every time since the invalidation would likely change them.
This commit is contained in:
PixelyIon 2021-12-27 00:32:01 +05:30
parent ff27dce24c
commit e48a7d7009
1 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
app/src/main/cpp/skyline/gpu/interconnect/graphics_context.h
View File

@ -543,10 +543,8 @@ namespace skyline::gpu::interconnect {
else if (constantBufferSelector.view)
return &*constantBufferSelector.view;
if (constantBufferSelector.guest.mappings.empty()) {
auto mappings{channelCtx.asCtx->gmmu.TranslateRange(constantBufferSelector.iova, constantBufferSelector.size)};
constantBufferSelector.guest.mappings.assign(mappings.begin(), mappings.end());
}
auto mappings{channelCtx.asCtx->gmmu.TranslateRange(constantBufferSelector.iova, constantBufferSelector.size)};
constantBufferSelector.guest.mappings.assign(mappings.begin(), mappings.end());
constantBufferSelector.view = gpu.buffer.FindOrCreate(constantBufferSelector.guest);
return constantBufferSelector.view.get();
@ -1259,7 +1257,6 @@ namespace skyline::gpu::interconnect {
vk::VertexInputBindingDescription bindingDescription{};
vk::VertexInputBindingDivisorDescriptionEXT bindingDivisorDescription{};
IOVA start{}, end{}; //!< IOVAs covering a contiguous region in GPU AS with the vertex buffer
GuestBuffer guest;
std::shared_ptr<BufferView> view;
};
std::array<VertexBuffer, maxwell3d::VertexBufferCount> vertexBuffers{};
@ -1476,12 +1473,11 @@ namespace skyline::gpu::interconnect {
else if (vertexBuffer.view)
return vertexBuffer.view.get();
if (vertexBuffer.guest.mappings.empty()) {
auto mappings{channelCtx.asCtx->gmmu.TranslateRange(vertexBuffer.start, (vertexBuffer.end + 1) - vertexBuffer.start)};
vertexBuffer.guest.mappings.assign(mappings.begin(), mappings.end());
}
GuestBuffer guest;
auto mappings{channelCtx.asCtx->gmmu.TranslateRange(vertexBuffer.start, (vertexBuffer.end + 1) - vertexBuffer.start)};
guest.mappings.assign(mappings.begin(), mappings.end());
vertexBuffer.view = gpu.buffer.FindOrCreate(vertexBuffer.guest);
vertexBuffer.view = gpu.buffer.FindOrCreate(guest);
return vertexBuffer.view.get();
}