Cleaning up some TODO messages

This commit is contained in:
James Mitchell 2020-05-24 11:44:26 +10:00
parent 897534aec6
commit 2363a22e3e

View File

@ -817,7 +817,6 @@ bool getVariant(HSQUIRRELVM vm, SQInteger idx, ScriptVariant_t& variant)
tag == TYPETAG_VECTOR && tag == TYPETAG_VECTOR &&
SQ_SUCCEEDED(sq_getinstanceup(vm, idx, (SQUserPointer*)&v, TYPETAG_VECTOR))) SQ_SUCCEEDED(sq_getinstanceup(vm, idx, (SQUserPointer*)&v, TYPETAG_VECTOR)))
{ {
// TODO: This actually ends up pointing to the same data it seems error prone
variant = new Vector(*v); variant = new Vector(*v);
variant.m_flags |= SV_FREE; variant.m_flags |= SV_FREE;
return true; return true;
@ -1206,11 +1205,13 @@ void SquirrelVM::Shutdown()
bool SquirrelVM::ConnectDebugger() bool SquirrelVM::ConnectDebugger()
{ {
// TODO: Debugger support
return false; return false;
} }
void SquirrelVM::DisconnectDebugger() void SquirrelVM::DisconnectDebugger()
{ {
// TODO: Debugger support
} }
ScriptLanguage_t SquirrelVM::GetLanguage() ScriptLanguage_t SquirrelVM::GetLanguage()
@ -1225,10 +1226,12 @@ const char* SquirrelVM::GetLanguageName()
void SquirrelVM::AddSearchPath(const char* pszSearchPath) void SquirrelVM::AddSearchPath(const char* pszSearchPath)
{ {
// TODO: Search path support
} }
bool SquirrelVM::Frame(float simTime) bool SquirrelVM::Frame(float simTime)
{ {
// TODO: Frame support
return false; return false;
} }
@ -1254,7 +1257,7 @@ ScriptStatus_t SquirrelVM::Run(const char* pszScript, bool bWait)
HSCRIPT SquirrelVM::CompileScript(const char* pszScript, const char* pszId) HSCRIPT SquirrelVM::CompileScript(const char* pszScript, const char* pszId)
{ {
SquirrelSafeCheck safeCheck(vm_); SquirrelSafeCheck safeCheck(vm_);
// TODO: sq_setcompilererrorhandler
Assert(vm_); Assert(vm_);
if (pszId == nullptr) pszId = "<unnamed>"; if (pszId == nullptr) pszId = "<unnamed>";
if (SQ_FAILED(sq_compilebuffer(vm_, pszScript, strlen(pszScript), pszId, SQTrue))) if (SQ_FAILED(sq_compilebuffer(vm_, pszScript, strlen(pszScript), pszId, SQTrue)))
@ -1300,7 +1303,6 @@ ScriptStatus_t SquirrelVM::Run(HSCRIPT hScript, HSCRIPT hScope, bool bWait)
sq_pop(vm_, 1); sq_pop(vm_, 1);
if (SQ_FAILED(result)) if (SQ_FAILED(result))
{ {
// TODO: sq_getlasterror
return SCRIPT_ERROR; return SCRIPT_ERROR;
} }
return SCRIPT_DONE; return SCRIPT_DONE;
@ -1316,7 +1318,6 @@ ScriptStatus_t SquirrelVM::Run(HSCRIPT hScript, bool bWait)
sq_pop(vm_, 1); sq_pop(vm_, 1);
if (SQ_FAILED(result)) if (SQ_FAILED(result))
{ {
// TODO: sq_getlasterror
return SCRIPT_ERROR; return SCRIPT_ERROR;
} }
return SCRIPT_DONE; return SCRIPT_DONE;
@ -2771,16 +2772,19 @@ void SquirrelVM::RemoveOrphanInstances()
void SquirrelVM::DumpState() void SquirrelVM::DumpState()
{ {
SquirrelSafeCheck safeCheck(vm_); SquirrelSafeCheck safeCheck(vm_);
// TODO: Dump state
} }
void SquirrelVM::SetOutputCallback(ScriptOutputFunc_t pFunc) void SquirrelVM::SetOutputCallback(ScriptOutputFunc_t pFunc)
{ {
SquirrelSafeCheck safeCheck(vm_); SquirrelSafeCheck safeCheck(vm_);
// TODO: Support output callbacks
} }
void SquirrelVM::SetErrorCallback(ScriptErrorFunc_t pFunc) void SquirrelVM::SetErrorCallback(ScriptErrorFunc_t pFunc)
{ {
SquirrelSafeCheck safeCheck(vm_); SquirrelSafeCheck safeCheck(vm_);
// TODO: Support error callbacks
} }
bool SquirrelVM::RaiseException(const char* pszExceptionText) bool SquirrelVM::RaiseException(const char* pszExceptionText)