From 99a8bdcb3723e752741a3c7b905ee73a2254ed12 Mon Sep 17 00:00:00 2001
From: MoofEMP <5711800-MoofEMP@users.noreply.gitlab.com>
Date: Tue, 27 Jul 2021 17:46:41 -0400
Subject: [PATCH] Use a variable for input string length in logic_substring

---
 sp/src/game/server/logic_substring.cpp | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/sp/src/game/server/logic_substring.cpp b/sp/src/game/server/logic_substring.cpp
index 648cf2fe..d1e9b96c 100644
--- a/sp/src/game/server/logic_substring.cpp
+++ b/sp/src/game/server/logic_substring.cpp
@@ -66,13 +66,14 @@ void CLogicSubstring::InputInValue( inputdata_t &inputData )
 {
 	if( !m_bEnabled ) return;
 
-	int startPosCheck = m_nStartPos < 0 ? Q_strlen(inputData.value.String()) + m_nStartPos : m_nStartPos;
+	int inputLength = Q_strlen(inputData.value.String());
+	int startPosCheck = m_nStartPos < 0 ? inputLength + m_nStartPos : m_nStartPos;
 	if( startPosCheck < 0 )
 	{
 		startPosCheck = 0;
 	}
-	int lengthCheck = (m_nLength < 0 || m_nLength > Q_strlen(inputData.value.String()) - startPosCheck ? Q_strlen(inputData.value.String()) - startPosCheck : m_nLength) + 1;
-	if( lengthCheck < 1 || startPosCheck > Q_strlen(inputData.value.String()) )
+	int lengthCheck = (m_nLength < 0 || m_nLength > inputLength - startPosCheck ? inputLength - startPosCheck : m_nLength) + 1;
+	if( lengthCheck < 1 || startPosCheck > inputLength )
 	{
 		m_OutValue.Set( MAKE_STRING(""), inputData.pActivator, this );
 		return;