From a1775d4afc45d62a9eb742061ffe11495c5102d2 Mon Sep 17 00:00:00 2001 From: Blixibon Date: Wed, 10 Jan 2024 14:17:44 -0600 Subject: [PATCH] Updated Reviewing Mapbase pull requests (markdown) --- Reviewing-Mapbase-pull-requests.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/Reviewing-Mapbase-pull-requests.md b/Reviewing-Mapbase-pull-requests.md index 4a93236..0d6ddf0 100644 --- a/Reviewing-Mapbase-pull-requests.md +++ b/Reviewing-Mapbase-pull-requests.md @@ -1,7 +1,5 @@ This guide will explain how to review a pull request on the Mapbase repository. -*Note that this guide is currently a work-in-progress.* - --- ## Quick summary of how pull requests work in Mapbase @@ -10,7 +8,7 @@ A pull request (or "PR") is a request to add code to the repository. Under most After a pull request is opened, it must pass the repository's automated checks. In Mapbase's case, GitHub Actions automatically builds the pull request's code on both Windows and Linux to ensure that it compiles properly. If the compilation fails, then the check fails. If it compiles properly, then the binaries will be made available for download by anyone with a GitHub account. -If all checks have succeeded, then the pull request must be manually reviewed and approved by other users. An approving review from at least 2 collaborators with write access is required in order for a pull request to be merged. +If all checks have succeeded, then the pull request must be manually reviewed and approved by other users. An approving review from at least 1 collaborator with write access is required in order for a pull request to be merged. Once a pull request is merged, it becomes "Closed" and is filed away.