mirror of
https://github.com/mapbase-source/source-sdk-2013.git
synced 2024-12-25 14:25:32 +03:00
Updated Reviewing Mapbase pull requests (markdown)
parent
089a46e96b
commit
d92284eabf
@ -40,7 +40,7 @@ Once you are on the pull request page, there are three things you will need to c
|
||||
|
||||
## Starting a review
|
||||
|
||||
Once you understand what the PR is supposed to do, you can find out what it changed by going to the **"Files changed"** tab. This will show you the differences between the pull request's code and the code of the branch it is being merged into.
|
||||
Once you understand what the PR is supposed to do, you can find out what it changed by going to the **"Files changed"** tab. This will show you the differences between the pull request's code and the code of the branch it is being merged into. New content is highlighted in green and removed content is highlighted in red.
|
||||
|
||||
![image](https://github.com/mapbase-source/source-sdk-2013/assets/19228257/a96f4338-83c5-4f28-9bcd-2bf9504a5c2f)
|
||||
|
||||
@ -72,7 +72,7 @@ Once you have written your comment, you should click on the **"Start a review"**
|
||||
|
||||
![image](https://github.com/mapbase-source/source-sdk-2013/assets/19228257/a4322310-eba6-4844-8770-ba744bbe1f46)
|
||||
|
||||
If this is the *only* comment you plan on making and you are not starting an actual review or request for changes, you can use the "Add single comment" button, but generally, you will want to start a full review.
|
||||
If this is the *only* comment you plan on making and you are not starting an actual approving review or request for changes, you can use the "Add single comment" button, but generally, you will want to start a full review.
|
||||
|
||||
After starting a review, you will be able to add other comments on other lines as part of one single review.
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user