Valve/Proton
1
0
Fork 0
mirror of https://github.com/ValveSoftware/Proton.git synced 2025-06-23 02:49:36 +03:00
Code Issues Packages Projects Releases Wiki Activity

lsteamclient: Avoid memory leak and frequent allocation in steamclient_Steam_BGetCallback().

Browse Source 
CW-Bug-Id: #24806
This commit is contained in:
Paul Gofman 2025-02-04 17:05:58 -06:00 committed by Arkadiusz Hiler
parent a0e69f1876
commit 8d4661b0f3
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lsteamclient/unixlib.cpp
View File

@ -306,13 +306,14 @@ static void (*p_Steam_NotifyMissingInterface)( int32_t, const char * );
template< typename Params > template< typename Params >
static NTSTATUS steamclient_Steam_BGetCallback( Params *params, bool wow64 ) static NTSTATUS steamclient_Steam_BGetCallback( Params *params, bool wow64 )
{ {
u_CallbackMsg_t *u_msg = new u_CallbackMsg_t(); u_CallbackMsg_t *u_msg, u_msg_tmp;
auto *w_msg = &*params->w_msg; auto *w_msg = &*params->w_msg;
if (!u_msg || !p_Steam_BGetCallback( params->pipe, u_msg, params->ignored )) if (!p_Steam_BGetCallback( params->pipe, &u_msg_tmp, params->ignored ))
params->_ret = false; params->_ret = false;
else else
{ {
u_msg = new u_CallbackMsg_t(u_msg_tmp);
TRACE( "id %d, u_size %d.\n", u_msg->m_iCallback, u_msg->m_cubParam ); TRACE( "id %d, u_size %d.\n", u_msg->m_iCallback, u_msg->m_cubParam );
w_msg->m_hSteamUser = u_msg->m_hSteamUser; w_msg->m_hSteamUser = u_msg->m_hSteamUser;
w_msg->m_iCallback = u_msg->m_iCallback; w_msg->m_iCallback = u_msg->m_iCallback;