reHLDS/rehlds
2
0
Fork 0
mirror of https://github.com/rehlds/rehlds.git synced 2025-01-28 22:48:05 +03:00
Code Issues Projects Releases Wiki Activity

SV_HandleClientMessage_api: loop break when got invalid message (as default behavior)

Browse Source
This commit is contained in:
s1lent 2019-08-11 03:01:49 +07:00
parent ed0e4fedcf
commit f3ae0987b9
No known key found for this signature in database
GPG Key ID: 0FE401DC73916B5C
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
rehlds/engine/sv_user.cpp
View File

@ -1730,6 +1730,10 @@ void EXT_FUNC SV_HandleClientMessage_api(IGameClient* client, int8 opcode) {
client_t* cl = client->GetClient(); client_t* cl = client->GetClient();
if (opcode < clc_bad || opcode > clc_cvarvalue2) if (opcode < clc_bad || opcode > clc_cvarvalue2)
{ {
// TODO: Are we forced to use msg_badread for break the loop.
static_assert(REHLDS_API_VERSION_MAJOR <= 3, "Bump major API DETECTED!! You shall rework the hookchain, make function returnable");
msg_badread = 1;
Con_Printf("SV_ReadClientMessage: unknown command char (%d)\n", opcode); Con_Printf("SV_ReadClientMessage: unknown command char (%d)\n", opcode);
SV_DropClient(cl, FALSE, "Bad command character in client command"); SV_DropClient(cl, FALSE, "Bad command character in client command");
return; return;
@ -1772,7 +1776,8 @@ void SV_ExecuteClientMessage(client_t *cl)
{ {
#ifdef REHLDS_FIXES #ifdef REHLDS_FIXES
Con_Printf("SV_ReadClientMessage: badread on %s\n", host_client->name); Con_Printf("SV_ReadClientMessage: badread on %s\n", host_client->name);
SV_ClientPrintf("Badread\n"); if (host_client->active)
SV_ClientPrintf("Badread\n");
#else // REHLDS_FIXES #else // REHLDS_FIXES
Con_Printf("SV_ReadClientMessage: badread\n"); Con_Printf("SV_ReadClientMessage: badread\n");
#endif // REHLDS_FIXES #endif // REHLDS_FIXES