MapBase/source-sdk-2013-mapbase
1
0
Fork 0
mirror of https://github.com/mapbase-source/source-sdk-2013.git synced 2025-01-12 23:07:55 +03:00
Code Issues Packages Projects Releases Wiki Activity

Updated Reviewing Mapbase pull requests (markdown)

Blixibon 2024-01-10 14:17:44 -06:00
parent d92284eabf
commit a1775d4afc
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Reviewing-Mapbase-pull-requests.md

@ -1,7 +1,5 @@
This guide will explain how to review a pull request on the Mapbase repository.
*Note that this guide is currently a work-in-progress.*
---
## Quick summary of how pull requests work in Mapbase
@ -10,7 +8,7 @@ A pull request (or "PR") is a request to add code to the repository. Under most
After a pull request is opened, it must pass the repository's automated checks. In Mapbase's case, GitHub Actions automatically builds the pull request's code on both Windows and Linux to ensure that it compiles properly. If the compilation fails, then the check fails. If it compiles properly, then the binaries will be made available for download by anyone with a GitHub account.
If all checks have succeeded, then the pull request must be manually reviewed and approved by other users. An approving review from at least 2 collaborators with write access is required in order for a pull request to be merged.
If all checks have succeeded, then the pull request must be manually reviewed and approved by other users. An approving review from at least 1 collaborator with write access is required in order for a pull request to be merged.
Once a pull request is merged, it becomes "Closed" and is filed away.