In steamrt-bootstrap,sh
+ Used quotes to prevent word splitting SC2046
+ Used $() notation rather than legacy backtick SC2006
+ which is non-standard. 'command -v' is builtin SC2230
In configure.sh
+ Assigned to local variable separately to avoid masking return values SC2155
+ Used to quote to prevent glob matching SC2053
+ Used -z command rather than ! -n SC2236
+ Fixed SC2129 which would have a minor performance gain of avoiding constantly opening and closing the makefile.
The makefile contains several bash-isms so set the SHELL variable to bash.
This fixes build errors on platforms where /bin/sh does not support bash extensions.
Signed-off-by: Huw Davies <huw@codeweavers.com>
If the makefile changes, dxvk tries to reconfigure (since the passed
args may be different), but meson only allows that with --reconfigure
Also fixes 'make dxvk_configure' multiple times
Such that 'make all deploy' or 'make all deploy install' work as
expected
Deploy/install don't imply all however - if iterating you may wish to
do e.g. 'make dxvk deploy' without waiting for a no-op wine build.
Ideally we'd track OUT files for everything, however, so a 'make
deploy' could at least build missing targets, if not dirty them.
The dist target would seem to need this treatment at first glance, but
it is actually doing prepare steps that only depend on wine being
ready
Fixes some races in parallel builds
These could all be listed in OBJ_DIRS above, but for specific nested
subdirectories having a mkdir -pv there is less error prone, if
verbose.
We didn't prefix any of our submake $(MAKE) invocations with +, so the
jobserver couldn't be used.
This also (so far?) seems to fix some problems I had with "make -j16"
(or anything higher than -j4) breaking due to some vrclient/steamclient
linkage problems.
Signed-off-by: Steven Noonan <steven@valvesoftware.com>
